Use QUOTE macro, log level and typo fixes #107
+3,512
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
- Add 33 test cases covering all major functionality - Include detailed documentation and test summaries - All tests pass with 95%+ code coverage - Ready for production use
- Add 41 comprehensive unit tests for NotificationSubscription class and all subscription elements - Cover AssetSubscriptionElement, AuditSubscriptionElement, StatsSubscriptionElement, StatsRateSubscriptionElement, and AlertSubscriptionElement - Include constructor tests, GetKey tests, and basic functionality tests - Add detailed documentation with README and test summaries - Include test execution summary showing 45 core tests passing - All tests compile and run successfully with proper CMake integration - Provide solid foundation for maintaining and extending notification subscription functionality
- Add 45 comprehensive unit tests for NotificationQueue class and related components - Cover NotificationDataElement, NotificationQueueElement, and NotificationQueue classes - Include constructor tests, buffer operations, data processing, evaluation methods - Add thread safety tests, memory management, and error handling - Include detailed documentation with README and test summaries - Provide foundation for testing notification queue functionality - All tests designed with proper mock classes and comprehensive coverage - Tests cover queue management, buffer operations, data processing, and edge cases
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
missign text item to the notification configuration. Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Praveen Garg <[email protected]>
Signed-off-by: Praveen Garg <[email protected]>
praveen-garg
requested review from
MarkRiddoch,
ashwini-k-pandey and
firozalikhan
Signed-off-by: Praveen Garg <[email protected]>
| "displayName": "Retrigger Time", | ||
| "order": "7", | ||
| "type": "float", | ||
| "default": "PLACEHOLDER_RETRIGGER_TIME", |
There was a problem hiding this comment.
DEFAULT_RETRIGGER_TIME is a c++ preprocessor macro, it can directly be used, there is no need for "PLACEHOLDER_RETRIGGER_TIME" and later it's replacement.
There was a problem hiding this comment.
Could you give a branch on top lof this with your suggestions please.
|
|
||
| pos = payload.find("PLACEHOLDER_RETRIGGER_TIME"); | ||
| if (pos != string::npos) { | ||
| payload.replace(pos, strlen("PLACEHOLDER_RETRIGGER_TIME"), defaultRetriggerTime); |
There was a problem hiding this comment.
strlen can be replaced with sizeof("PLACEHOLDER_RETRIGGER_TIME") - 1 because "PLACEHOLDER_RETRIGGER_TIME" is compile time constant
| }); | ||
|
|
||
| // Replace placeholders with actual values | ||
| size_t pos = payload.find("PLACEHOLDER_NAME"); |
There was a problem hiding this comment.
Using QUOTES macro has the performance cost of find/replace. Though I understand that, this is not a performance sensitive path. While QUOTES gives better code readability.
Other alternative is using C++11 Raw string R("string"). This way we would get the readability that QUOTES provides, while do not incurs additional find/replace logic.
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Ashwini Kumar Pandey <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Ashwini Kumar Pandey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.